Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming throughout example code #80

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 18, 2018

No description provided.

@djc
Copy link
Contributor Author

djc commented Jun 18, 2018

Looking at it a bit more, I'm not really sure having the code from the example in the documentation root is worth it as it is right now: it is at the same time pretty elaborate but also leaves out some essential details that you need to understand to be able to grok the code. Also, given that it's ignored by rustc, it will likely grow more outdated and/or inconsistent over time. Given all this, it might be better to redirect to the single_mem_node example for actual code.

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear
Copy link
Contributor

@djc Hi! Yes you may notice #70 has this same concern.

@Hoverbear Hoverbear merged commit fb292a7 into tikv:master Jun 19, 2018
@Hoverbear Hoverbear added this to the 0.3.1 milestone Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants